Repository navigation
Pilot plotly for the Python second-order-condition 3D figure - #660
Conversation
…output The matplotlib figure stays as the static fallback for PDF and Word. Closes #659. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pyVsdgfFPiYDQB7ko
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…d-call lint Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pyVsdgfFPiYDQB7ko
|
Claude finished review — View run I fetched PR #660 live just now. It is open, not a draft, and not merged ( VerdictReady for merge. No new findings. The prior review of Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "18d64d2d920c291b40a3f77c674eed37fbf6efe2",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The optimization.qmd change binds the package vector to py_packages before calling reticulate::py_require; the package list is unchanged and the name does not collide with anything else in that file.",
"holistic_assessment": "The commit is a lint-only refactor with no behavior change, so the prior verdict stands; the open item is still the visual check of the Python tab in the PR preview."
}Reviewed commit: 18d64d2 |
Built to branch |
|
Annotations reviewed: 18d64d2. They are the Ubuntu 26 runner-label notices, the anonymous-submodule notice, a diff-highlighting cap notice, and one Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
* Draw four more Python 3D figures with plotly (batch 2) Refs #664. Follows #660 and Morrison-Lab/psw#500: plotly for HTML and slides, matplotlib kept as the -static chunk for PDF and Word. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pyVsdgfFPiYDQB7ko * Request plotly in the contour-line figure's own requirements The figure subfile declares its Python packages, so a page that includes it (algebra.qmd through _algebra.qmd, or an external host) gets plotly without its own py_require. Drops the page-level chunk that is now redundant. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pyVsdgfFPiYDQB7ko --------- Co-authored-by: Claude <noreply@anthropic.com>
Requested by Ezra · project thread
Closes #659.
What changed
/home/user/mds/_subfiles/vector-calc/_fig-second-order-condition-3d.qmd: the Python tab draws the two surfaces with plotly (make_subplotswith two 3D scenes, same colors, camera and markers as the R tab) in HTML and slide output.second-order-condition-3d-python-staticand runs only for non-HTML output (PDF, Word), the same split the R tab already uses. No kaleido is needed.optimization-critical-points.qmdandoptimization.qmdaddplotlyto theirpy_requirelists.Implementation notes
fig.to_html(full_html=False, include_plotlyjs="cdn")) in a singleprint, becausefig.show()needs ipython and several prints split the knitr output.;on theadd_traceandupdate_layoutcalls stops reticulate from auto-printing the returned figure.Checks
quarto render optimization-critical-points.qmd --to htmlexits 0 with no div or knitr warnings (the downlit/xml2 warning is also onmain); the output holds the plotly div with both scenes.optimization.qmd.Generated by Claude Code